Re: [Qemu-devel] [PATCH v7 1/2] dump: Propagate errors into qmp_dump_guest_memory()

[Eric Blake]

On 09/30/2014 03:20 AM, zhanghailiang wrote:
> The code calls dump_error() on error, and even passes it a suitable
> message.  However, the message is thrown away, and its callers pass
> up only success/failure.  All qmp_dump_guest_memory() can do is set
> a generic error.
> 
> Propagate the errors properly, so qmp_dump_guest_memory() can return
> a more useful error.
> 
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
>  dump.c | 165 
> ++++++++++++++++++++++++++++++++---------------------------------
>  1 file changed, 82 insertions(+), 83 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature