[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-balloon: Tweak recent fix for integer ov
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-balloon: Tweak recent fix for integer overflow |
Date: |
Thu, 9 Oct 2014 09:49:37 -0400 |
On Wed, 1 Oct 2014 18:43:44 +0200
Markus Armbruster <address@hidden> wrote:
> Commit 1f9296b avoids "other kinds of overflow" by limiting the
> polling interval to UINT_MAX. The computations to protect are done in
> 64 bits. This is indeed safe when unsigned is 32 bits, as it commonly
> is. It isn't when unsigned is 64 bits. Purely theoretical; I'm not
> aware of such a system. Limit it to UINT32_MAX instead.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Applied to the qmp branch, thanks.
> ---
> hw/virtio/virtio-balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index b5cf7ca..7bfbb75 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -170,7 +170,7 @@ static void balloon_stats_set_poll_interval(Object *obj,
> struct Visitor *v,
> return;
> }
>
> - if (value > UINT_MAX) {
> + if (value > UINT32_MAX) {
> error_setg(errp, "timer value is too big");
> return;
> }