Re: [Qemu-devel] [PATCH 1/1] target-i386: prevent users from setting threads>1 for AMD CPUs

[Paolo Bonzini]

Il 09/10/2014 22:22, Wei Huang ha scritto:
> 
> Given that back-ward compatibility is a concern, will the following work?
> 
> 1. Instead of bailing out, print a warning message (e.g. to log file via
> error_report) in QEMU.
> 2. [optional] Eduardo Habkost suggested that we can create a new machine
> model which more strictly checks threads=n option for AMD. For any
> existing machine config, we don't force it; but warning message still
> applies. This is optional because it is a bit over-killed IMO.
> 3. Gives out a warning in virt-manager as well. This is similar to
> "Overcomming CPUs will slow down performance" in current virt-manager
> screen. The message will read "Chosen CPU model doesn't support
> hyperthreading" or something similar.

I like (1) and (3).

Paolo