[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2] LEON3: Add emulation of AMBA plug&play
|
From: |
Fabien Chouteau |
|
Subject: |
Re: [Qemu-devel] [PATCH V2] LEON3: Add emulation of AMBA plug&play |
|
Date: |
Fri, 10 Oct 2014 11:04:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 |
On 10/09/2014 05:32 PM, Jiri Gaisler wrote:
>
> I am a bit against the merge of AHB and APB initialization into
> the same function. A grlib system can have any number of AHB and APB
> buses, so there really should be a separate init routine per bus
> as in the original patch.
>
I understand your concerns, for the moment the system definition of
leon3 is very static, and I don't see that we will need more flexibility
in the near future. In that case I think it's better to not add
unnecessary complexity in the code.