qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch6


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64
Date: Fri, 10 Oct 2014 16:30:31 +0100

On 10 October 2014 15:58, Claudio Fontana <address@hidden> wrote:
> On 10.10.2014 13:32, Peter Maydell wrote:
>> Thanks for catching this. Better to fix it by dropping
>> the unnecessary local variable completely and just setting
>>   info._sifields._sigfault._addr = env->exception.vaddress;
>> at the only point where we currently use 'addr', though,
>> I think.

> We do use the name code pattern in most of the functions of that file,
> meaning
>
> uint32_t / uint64_t / target_ulong addr;
>
> and then do_something_with_addr(addr);

In other functions the variable is used more than once,
mostly. (In cases where it is not I would also be happy
with cleanup patches which removed it.)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]