[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction |
|
Date: |
Fri, 10 Oct 2014 10:13:56 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
On 09/10/2014 11:05 PM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> qapi-schema.json | 3 +++
> 2 files changed, 51 insertions(+)
>
> +++ b/qapi-schema.json
> @@ -1251,11 +1251,14 @@
> #
> # A discriminated record of operations that can be performed with
> # @transaction.
> +#
> +# Since 1.1, blockdev-backup since 2.1
If we're going to do this, we should be accurate. s/2.1/2.2. Furthermore:
drive-backup and abort were added in 1.6
blockdev-snapshot-internal-sync was added in 1.7
(but yes, I'm glad that you are wanting to add version information).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature