[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] libvixl: a64: Skip "-Wunused-variable" for g
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] libvixl: a64: Skip "-Wunused-variable" for gcc 5.0.0 or higher |
Date: |
Sun, 12 Oct 2014 08:50:11 +0100 |
On 12 October 2014 01:32, Chen Gang <address@hidden> wrote:
> On 10/12/14 5:25, Peter Maydell wrote:
>> Some other approaches to this that would confine the
>> fix to the makefiles rather than requiring us to modify
>> the vixl source itself:
>> a) add a -Wno- option for the affected .o files
>
> It is one way, but may have effect with gcc 4 version, and also it is
> effect with the whole file which is wider than current way.
>
>> b) use -isystem rather than -I to include the libvixl
>> directory on the include path
>>
>
> It sounds good to me, although for me, it is not related with current
> issue.
-isystem disables a bunch of gcc warnings automatically,
which is why I suggested it. I'm not overall sure it's
a great idea though.
-- PMM