Re: [Qemu-devel] [PATCH] target-arm: A64: remove redundant store

[Laurent Desnogues]

On Tue, Oct 14, 2014 at 3:08 PM, Alex Bennée <address@hidden> wrote:
> There is not much point storing the same value twice in a row.
>
> Reported-by: Laurent Desnogues <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>

Reviewed-by: Laurent Desnogues <address@hidden>

Thanks,

Laurent

> ---
>  target-arm/translate-a64.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 35ae3ea..337f4d4 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -748,7 +748,6 @@ static void do_fp_st(DisasContext *s, int srcidx, 
> TCGv_i64 tcg_addr, int size)
>      } else {
>          TCGv_i64 tcg_hiaddr = tcg_temp_new_i64();
>          tcg_gen_qemu_st_i64(tmp, tcg_addr, get_mem_index(s), MO_TEQ);
> -        tcg_gen_qemu_st64(tmp, tcg_addr, get_mem_index(s));
>          tcg_gen_ld_i64(tmp, cpu_env, fp_reg_hi_offset(s, srcidx));
>          tcg_gen_addi_i64(tcg_hiaddr, tcg_addr, 8);
>          tcg_gen_qemu_st_i64(tmp, tcg_hiaddr, get_mem_index(s), MO_TEQ);
> --
> 2.1.1
>