qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] glib: add compatibility interface for g_get_


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] glib: add compatibility interface for g_get_monotonic_time()
Date: Wed, 15 Oct 2014 12:47:48 +0200

On 15 October 2014 12:10, Igor Mammedov <address@hidden> wrote:
> From: Stefan Hajnoczi <address@hidden>
>
> This patch fixes compilation errors when building against glib <2.28.0
> due to the missing g_get_monotonic_time() function.
>
> The compilation error in tests/libqos/virtio.c was introduced in commit
> 70556264a89a268efba1d7e8e341adcdd7881eb4 ("libqos: use microseconds
> instead of iterations for virtio timeout").
>
> Add a simple g_get_monotonic_time() implementation to compat-glib.h
> based on code from vhost-user-test.c.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>

Unfortunately this patch doesn't actually fix the test compile
failure, because it puts the replacement implementation in
compat-glib.h which is not included from the libqos sources.

Adding #include "compat-glib.h" to tests/libqtest.h seems to
fix this.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]