[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH qom v4 11/13] qdev: gpio: Remove qdev_init_gpio_out
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH qom v4 11/13] qdev: gpio: Remove qdev_init_gpio_out x1 restriction |
Date: |
Fri, 17 Oct 2014 18:24:53 +0200 |
From: Peter Crosthwaite <address@hidden>
Previously this was restricted to a single call per-dev/per-name. With
the conversion of the GPIO output state to QOM the implementation can
now handle repeated calls. Remove the restriction.
Reviewed-by: Alexander Graf <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/core/qdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 8550486..c143cd0 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -367,8 +367,7 @@ void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq
*pins,
char *propname = g_strdup_printf("%s[*]", name ? name :
"unnamed-gpio-out");
assert(gpio_list->num_in == 0 || !name);
- assert(gpio_list->num_out == 0);
- gpio_list->num_out = n;
+ gpio_list->num_out += n;
for (i = 0; i < n; ++i) {
memset(&pins[i], 0, sizeof(*pins));
--
2.1.0
- [Qemu-devel] [PATCH qom v4 02/13] qdev: gpio: Register GPIO inputs as child objects, (continued)
- [Qemu-devel] [PATCH qom v4 02/13] qdev: gpio: Register GPIO inputs as child objects, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 03/13] qdev: gpio: Register GPIO outputs as QOM links, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 01/13] qdev: gpio: Don't allow name share between I and O, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 04/13] qom: Allow clearing of a Link property, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 05/13] qom: Demote already-has-a-parent to a regular error, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 06/13] qdev: gpio: Re-implement qdev_connect_gpio QOM style, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 07/13] qdev: gpio: Add API for intercepting a GPIO, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 08/13] qtest/irq: Rework IRQ interception, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 09/13] irq: Remove qemu_irq_intercept_out, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 10/13] qdev: gpio: delete NamedGPIOList::out, Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 11/13] qdev: gpio: Remove qdev_init_gpio_out x1 restriction,
Paolo Bonzini <=
- [Qemu-devel] [PATCH qom v4 12/13] qdev: gpio: Define qdev_pass_gpios(), Paolo Bonzini, 2014/10/17
- [Qemu-devel] [PATCH qom v4 13/13] sysbus: Use TYPE_DEVICE GPIO functionality, Paolo Bonzini, 2014/10/17
- Re: [Qemu-devel] [PATCH qom v4 00/13] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs, Peter Crosthwaite, 2014/10/19