qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Patch checking bot


From: Peter Maydell
Subject: Re: [Qemu-devel] Patch checking bot
Date: Mon, 20 Oct 2014 15:08:35 +0100

On 20 October 2014 11:25, Stefan Hajnoczi <address@hidden> wrote:
> Hi,
> At KVM Forum 2014 we discussed a patch checking bot that automates patch
> format checking and smoke testing:
>
> 1. Did the patch submitter include Signed-off-by?
> 2. Does checkpatch.pl pass?
> 3. Does the patch apply to qemu.git/master?
> 4. Does each patch compile?
> 5. Does the series pass make check and qemu-iotests?
>
> Here are some thoughts on the patch checker:
>
> If a patch series passes successfully, no email is sent.  If a patch
> series fails, an email with the errors is sent as a reply to the patch
> series email thread.  The patch submitter can then respond in case there
> are false positive (e.g. from checkpatch.pl) - the bot doesn't care
> about replies but it tells the human reviewers and maintainers what the
> patch submitter intends to do.

Probably also worth having a feature where the cover
letter or patch can have a "patchchecker: no" line in
it to tell the bot to ignore something, so people can
avoid it sending lots of mail for patch series they
know don't apply to mainline (eg ones which depend on
a previous series).

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]