Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

[Michael S. Tsirkin]

On Tue, Oct 21, 2014 at 01:23:49PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > > How about making "get_maintainer.pl --git-fallback" actually do what it
> > > says?  Right now git it *not* used as fallback, it goes to git log
> > > unconditionally, even if there are hits in MAINTAINERS ...
> > 
> > It does?
> > 
> > How do you reproduce this behaviour?
> > 
> > $ ./scripts/get_maintainer.pl -f vl.c
> > Anthony Liguori <address@hidden> (supporter:Main loop)
> > 
> > Seems to stop if it sees a maintainer.
> 
> nilsson kraxel ~/projects/qemu (usb.work)# scripts/get_maintainer.pl -f
> ui/vnc.c
> Anthony Liguori <address@hidden> (odd fixer:Graphics)
> Gerd Hoffmann <address@hidden> (odd
> fixer:Graphics,commit_signer:21/24=88%)
> Peter Lieven <address@hidden> (commit_signer:12/24=50%)
> Wenchao Xia <address@hidden> (commit_signer:7/24=29%)
> Markus Armbruster <address@hidden> (commit_signer:3/24=12%)
> Luiz Capitulino <address@hidden> (commit_signer:3/24=12%)
> 
> Maybe it depends on maintainer status ...
> 
> cheers,
>   Gerd
> 

Yes and that's a bug.
Thanks for the report.
Patch send, maybe that will be enough.


-- 
MST