Re: [Qemu-devel] [PATCH v2] vfio: migration to trace points

[Alex Williamson]

On Tue, 2014-09-30 at 07:47 +0100, Eric Auger wrote:
> This patch removes all DPRINTF and replace them by trace points.
> A few DPRINTF used in error cases were transformed into error_report.
> 
> Signed-off-by: Eric Auger <address@hidden>
> 
> ---
> 
> - __func__ is removed since trace point name does the same job
> - HWADDR_PRIx were replaced by PRIx64
> - this transformation just is tested compiled on PCI.
>   qemu configured with --enable-trace-backends=stderr
> - in future, format strings and calls may be simplified by using a single
>   name argument instead of domain, bus, slot, function.
> 
> v1 (RFC) -> v2 (PATCH):
> - restore original format strings since parsing now is OK after
>   commit f9bbba9,
>   [PATCH v2] trace: tighten up trace-events regex to fix bad parse
> ---
>  hw/misc/vfio.c | 403 
> +++++++++++++++++++++++++++++----------------------------
>  trace-events   |  75 ++++++++++-
>  2 files changed, 280 insertions(+), 198 deletions(-)

Thanks for this conversion Eric.  I'll do some testing and make sure it
does what I need and put it in after QEMU 2.2 if there are no issues.
Thanks,

Alex