Re: [Qemu-devel] [PATCH] scripts/get_maintainer.pl: allow "odd fixes"

[Michael S. Tsirkin]

On Tue, Oct 21, 2014 at 02:35:09PM +0300, Michael S. Tsirkin wrote:
> We have a bunch of modules in "Odd fixes"
> status, scripts/get_maintainer.pl ignores that.
> 
> Reported-by: Gerd Hoffmann <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Actually, it does not ignore that.
What it does it list status as "odd fixer".

So this boils down to the fact that we use
"odd fixer" incorrectly.

I will apply this for now but maybe we should
change MAINTAINERS switching all "Odd fixes" to
"Maintained" and then revert this patch.

Thoughts?

> ---
>  scripts/get_maintainer.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 38334de..d5eee8c 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -514,7 +514,7 @@ sub range_is_maintained {
>           my $type = $1;
>           my $value = $2;
>           if ($type eq 'S') {
> -             if ($value =~ /(maintain|support)/i) {
> +             if ($value =~ /(maintain|support|fix)/i) {
>                   return 1;
>               }
>           }
> -- 
> MST