[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same |
Date: |
Wed, 22 Oct 2014 11:08:20 +0200 |
Why should get_maintainer bother if someone puts his name as maintainer
on an "Orphan" entry? Garbage in, email out. The results from the git
fallback are likely to be from someone doing sweeping changes on the
whole tree, and thus not really interesting.
Reported-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/get_maintainer.pl | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index a3a16d8..6c5a73b 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -505,24 +505,6 @@ if ($web) {
exit($exit);
-sub range_is_maintained {
- my ($start, $end) = @_;
-
- for (my $i = $start; $i < $end; $i++) {
- my $line = $typevalue[$i];
- if ($line =~ m/^(\C):\s*(.*)/) {
- my $type = $1;
- my $value = $2;
- if ($type eq 'S') {
- if ($value =~ /(maintain|support)/i) {
- return 1;
- }
- }
- }
- }
- return 0;
-}
-
sub range_has_maintainer {
my ($start, $end) = @_;
@@ -602,7 +584,6 @@ sub get_maintainers {
$value_pd++ if (substr($value,-1,1) ne "/");
$value_pd = -1 if ($value =~ /^\.\*/);
if ($value_pd >= $file_pd &&
- range_is_maintained($start, $end) &&
range_has_maintainer($start, $end)) {
$exact_pattern_match_hash{$file} = 1;
}
--
1.8.3.1
- Re: [Qemu-devel] [PATCH 1/4] get_maintainer.pl: exit with status 1 if no maintainer found, (continued)
- [Qemu-devel] [PATCH 3/4] get_maintainer.pl: move git loop under "if ($email) {", Paolo Bonzini, 2014/10/22
- [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Michael S. Tsirkin, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Thomas Huth, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Michael S. Tsirkin, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Paolo Bonzini, 2014/10/22
- Re: [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically, Markus Armbruster, 2014/10/22
[Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same,
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl, Thomas Huth, 2014/10/22
Re: [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl, Markus Armbruster, 2014/10/22