Re: [Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same

[Michael S. Tsirkin]

On Wed, Oct 22, 2014 at 11:08:20AM +0200, Paolo Bonzini wrote:
> Why should get_maintainer bother if someone puts his name as maintainer
> on an "Orphan" entry?  Garbage in, email out.  The results from the git
> fallback are likely to be from someone doing sweeping changes on the
> whole tree, and thus not really interesting.
> 
> Reported-by: Gerd Hoffmann <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Looks good to me

Reviewed-by: Michael S. Tsirkin <address@hidden>

I will add text that explains that the effect for current tree is
disabling fallback for Odd fixes projects.


> ---
>  scripts/get_maintainer.pl | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index a3a16d8..6c5a73b 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -505,24 +505,6 @@ if ($web) {
>  
>  exit($exit);
>  
> -sub range_is_maintained {
> -    my ($start, $end) = @_;
> -
> -    for (my $i = $start; $i < $end; $i++) {
> -     my $line = $typevalue[$i];
> -     if ($line =~ m/^(\C):\s*(.*)/) {
> -         my $type = $1;
> -         my $value = $2;
> -         if ($type eq 'S') {
> -             if ($value =~ /(maintain|support)/i) {
> -                 return 1;
> -             }
> -         }
> -     }
> -    }
> -    return 0;
> -}
> -
>  sub range_has_maintainer {
>      my ($start, $end) = @_;
>  
> @@ -602,7 +584,6 @@ sub get_maintainers {
>                               $value_pd++ if (substr($value,-1,1) ne "/");
>                               $value_pd = -1 if ($value =~ /^\.\*/);
>                               if ($value_pd >= $file_pd &&
> -                                 range_is_maintained($start, $end) &&
>                                   range_has_maintainer($start, $end)) {
>                                   $exact_pattern_match_hash{$file} = 1;
>                               }
> -- 
> 1.8.3.1
>