Re: [Qemu-devel] [PATCH 1/4] get_maintainer.pl: exit with status 1 if no maintainer found

[Paolo Bonzini]

> Thus, the patch makes the script exit with status 1 when none of the
> above output() calls produces output.
> 
> Maybe it exits with status 1 when it fails to produce output?  Obvious
> ouput elsewhere: printing the version (okay),

That exits with 0.

> and a print in get_maintainers().  Can't tell what the latter does.  Hmm.

That is for --sections, and you're right, this is missing:

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index f4fee27..e682d1f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -617,6 +617,7 @@ sub get_maintainers {
                    print("$line\n");
                }
                print("\n");
+               $exit = 0;
            }
        }
     }

Paolo