Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for map commands

[Max Reitz]

On 2014-10-22 at 15:54, Max Reitz wrote:
> On 2014-10-22 at 15:51, Kevin Wolf wrote:
> > Am 22.10.2014 um 15:24 hat Max Reitz geschrieben:
> > > Add a test for qemu-img map and qemu-io -c map on truncated files.
> > >
> > > Signed-off-by: Max Reitz <address@hidden>
> > Reviewed-by: Kevin Wolf <address@hidden>
> >
> > But how about adding a case for patch 2, too? Or is that one mostly
> > theoretical (like the image file being modified in the background) and
> > not reproducible reliably?
>
> See the cover letter, I could not find a way to test patch 2 without 
> triggering the changes introduced by patch 1. Yes, modifying the image 
> in the background could be a way to do this. I could try, but I don't 
> know if we really need a test for it.
>
> I'll give myself a couple of minutes and if it doesn't work, well, 
> then this test stays the same in v3.

And I just realized that my series "raw-posix: Fix 
raw_co_get_block_status()" contains exactly such a test, which is also 
the reason why it doesn't work without this series.

Max