[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 1/6] block: add accounting for merged requests
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv2 1/6] block: add accounting for merged requests |
Date: |
Wed, 22 Oct 2014 12:20:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/22/2014 07:21 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block.c | 2 ++
> block/accounting.c | 7 +++++++
> block/qapi.c | 2 ++
> hmp.c | 6 +++++-
> include/block/accounting.h | 3 +++
> qapi/block-core.json | 9 ++++++++-
> 6 files changed, 27 insertions(+), 2 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -392,13 +392,20 @@
> # growable sparse files (like qcow2) that are used on top
> # of a physical device.
> #
> +# @rd_merged: Reserved (Since 2.2)
Does this mean it is always output as 0 for now, but may be non-zero at
some future date if we figure out how to do merged read requests? Is it
even worth adding the field if it has no semantics? We can always add
it later when it makes sense, and a client can be smart enough to
realize that a missing field is the same as the field being present with
value 0 (since that is what clients already have to do for 2.1).
I'd feel better with just a bit more documentation or else omitting the
field. The rest of the patch is okay, though.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCHv2 0/6] multiwrite patches for 2.2, Peter Lieven, 2014/10/22
- [Qemu-devel] [PATCHv2 4/6] hw/virtio-blk: add a constant for max number of merged requests, Peter Lieven, 2014/10/22
- [Qemu-devel] [PATCHv2 2/6] block: introduce bdrv_runtime_opts, Peter Lieven, 2014/10/22
- [Qemu-devel] [PATCHv2 3/6] block: add a knob to disable multiwrite_merge, Peter Lieven, 2014/10/22
- [Qemu-devel] [PATCHv2 1/6] block: add accounting for merged requests, Peter Lieven, 2014/10/22
- Re: [Qemu-devel] [PATCHv2 1/6] block: add accounting for merged requests,
Eric Blake <=
- [Qemu-devel] [PATCHv2 6/6] block: fix qemu-iotest reference output for test 067, Peter Lieven, 2014/10/22
- [Qemu-devel] [PATCHv2 5/6] block: add qemu-iotest for write-merge parameter, Peter Lieven, 2014/10/22