qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 0


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 040 and 041
Date: Thu, 23 Oct 2014 12:07:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 2014-10-23 at 12:06, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
As of a follow-up patch to this one, the length of a mirror block job
will no longer directly depend on the size of the block device;
therefore, drop these checks from this test. Instead, just check whether
the final offset equals the block job length.

As 041 uses the wait_until_completed function from iotests.py, the same
applies there as well which in turn affects tests 030, 055 and 056. On
the other hand, a block job's length does not have to be related to the
length of the image file in the first place, so that check was
questionable anyway.

Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Possibly a result of rebasing over a long time, but 041 still has some
checks of len left after this patch.

Very likely, yes. I'll fix it.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]