Re: [Qemu-devel] [PATCH v13 11/14] qemu-img: Specify backing file for commit

[Kevin Wolf]

Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Introduce a new parameter for qemu-img commit which may be used to
> explicitly specify the backing file into which an image should be
> committed if the backing chain has more than a single layer.
> 
> Signed-off-by: Max Reitz <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>

> +If the backing chain of the given image file @var{filename} has more than one
> +layer, the backing file into which the changes will be committed may be
> +specified as @var{base} (which has to be part of @var{filename}'s backing
> +chain). If @var{base} is not specified, the immediate backing file of the top
> +image (which is @var{filename}) will be used. For reasons of consistency,
> +explicitly specifying @var{base} will always imply @code{-d}.

Wouldn't hurt, though, to be more explicit about the "reasons of
consistency". Took me a few moments to understand.

Kevin