[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm: fix TB alignment check
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] arm: fix TB alignment check |
|
Date: |
Thu, 23 Oct 2014 09:33:27 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
On 10/23/2014 09:25 AM, Peter Maydell wrote:
> On 23 October 2014 17:15, Richard Henderson <address@hidden> wrote:
>> [1] Why 32 when the maximum insn size is more like 15 bytes, I don't know.
>> But
>> it likely doesn't matter since I'd expect such large TB's to fill up the
>> opcode
>> buffer first. There would have to be a lot of nops on that page.
>
> Do we actually correctly GPF if the guest hands us an instruction
> with a huge long set of prefix bytes? I can't see anything obviously
> in the code that catches this case...
No, I don't think we check for that at all.
r~