qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v14 06/14] iotests: Omit length/offset test in 0


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v14 06/14] iotests: Omit length/offset test in 040 and 041
Date: Fri, 24 Oct 2014 09:14:18 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 10/24/2014 07:57 AM, Max Reitz wrote:
> As of a follow-up patch to this one, the length of a mirror block job
> will no longer directly depend on the size of the block device;
> therefore, drop these checks from this test. Instead, just check whether
> the final offset equals the block job length.
> 
> As 041 uses the wait_until_completed function from iotests.py, the same
> applies there as well which in turn affects tests 030, 055 and 056. On
> the other hand, a block job's length does not have to be related to the
> length of the image file in the first place, so that check was
> questionable anyway.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/040        | 4 +---
>  tests/qemu-iotests/041        | 5 +----
>  tests/qemu-iotests/iotests.py | 3 +--
>  3 files changed, 3 insertions(+), 9 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]