Re: [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP

[Eric Blake]

On 10/24/2014 07:57 AM, Max Reitz wrote:
> qemu-img should use QMP commands whenever possible in order to ensure
> feature completeness of both online and offline image operations. As
> qemu-img itself has no access to QMP (since this would basically require
> just everything being linked into qemu-img), imitate QMP's
> implementation of block-commit by using commit_active_start() and then
> waiting for the block job to finish.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block/Makefile.objs |  3 +--
>  qemu-img.c          | 78 
> ++++++++++++++++++++++++++++++++++++++++-------------
>  2 files changed, 60 insertions(+), 21 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature