qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 23/28] get_maintainer.pl: move git loop under "if ($e


From: Paolo Bonzini
Subject: [Qemu-devel] [PULL 23/28] get_maintainer.pl: move git loop under "if ($email) {"
Date: Mon, 27 Oct 2014 16:13:40 +0100

All checks in the loop are guarded by that condition, and there is a
handy "if" just below.  Simplify the code.

Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 scripts/get_maintainer.pl | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 38334de..906dcbe 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -651,18 +651,17 @@ sub get_maintainers {
        $email->[0] = deduplicate_email($email->[0]);
     }
 
-    foreach my $file (@files) {
-       if ($email &&
-           ($email_git || ($email_git_fallback &&
-                           !$exact_pattern_match_hash{$file}))) {
-           vcs_file_signoffs($file);
-       }
-       if ($email && $email_git_blame) {
-           vcs_file_blame($file);
+    if ($email) {
+       foreach my $file (@files) {
+           if ($email_git || ($email_git_fallback &&
+                              !$exact_pattern_match_hash{$file})) {
+               vcs_file_signoffs($file);
+           }
+           if ($email_git_blame) {
+               vcs_file_blame($file);
+           }
        }
-    }
 
-    if ($email) {
        foreach my $chief (@penguin_chief) {
            if ($chief =~ m/^(.*):(.*)/) {
                my $email_address;
-- 
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]