[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/28] get_maintainer.pl: move git loop under "if ($e
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 23/28] get_maintainer.pl: move git loop under "if ($email) {" |
Date: |
Mon, 27 Oct 2014 16:13:40 +0100 |
All checks in the loop are guarded by that condition, and there is a
handy "if" just below. Simplify the code.
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/get_maintainer.pl | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 38334de..906dcbe 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -651,18 +651,17 @@ sub get_maintainers {
$email->[0] = deduplicate_email($email->[0]);
}
- foreach my $file (@files) {
- if ($email &&
- ($email_git || ($email_git_fallback &&
- !$exact_pattern_match_hash{$file}))) {
- vcs_file_signoffs($file);
- }
- if ($email && $email_git_blame) {
- vcs_file_blame($file);
+ if ($email) {
+ foreach my $file (@files) {
+ if ($email_git || ($email_git_fallback &&
+ !$exact_pattern_match_hash{$file})) {
+ vcs_file_signoffs($file);
+ }
+ if ($email_git_blame) {
+ vcs_file_blame($file);
+ }
}
- }
- if ($email) {
foreach my $chief (@penguin_chief) {
if ($chief =~ m/^(.*):(.*)/) {
my $email_address;
--
1.8.3.1
- [Qemu-devel] [PULL 16/28] MAINTAINERS: grab more files from Anthony's pile, (continued)
- [Qemu-devel] [PULL 16/28] MAINTAINERS: grab more files from Anthony's pile, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 15/28] target-i386: warns users when CPU threads>1 for non-Intel CPUs, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 18/28] MAINTAINERS: add myself for X86, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 19/28] MAINTAINERS: Add more TCG files, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 20/28] MAINTAINERS: add some tests directories, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 17/28] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 21/28] MAINTAINERS: avoid M entries that point to mailing lists, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 23/28] get_maintainer.pl: move git loop under "if ($email) {",
Paolo Bonzini <=
- [Qemu-devel] [PULL 24/28] get_maintainer.pl: restrict cases where it falls back to --git, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 25/28] target-i386: add Intel AVX-512 support, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 22/28] qtest: fix qtest log fd should be initialized before qtest chardev, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 26/28] virtio-scsi: sense in virtio_scsi_command_complete, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 27/28] hw/scsi/virtio-scsi.c: fix the "type" use error in virtio_scsi_handle_ctrl, Paolo Bonzini, 2014/10/27
- [Qemu-devel] [PULL 28/28] aio / timers: De-document -clock, Paolo Bonzini, 2014/10/27
- Re: [Qemu-devel] [PULL 00/28] Changes for 2014-10-27, Andreas Färber, 2014/10/27
- Re: [Qemu-devel] [PULL 00/28] Changes for 2014-10-27, Peter Maydell, 2014/10/28