[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] target-arm: Correct condition for taking VI
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] target-arm: Correct condition for taking VIRQ and VFIQ |
|
Date: |
Mon, 27 Oct 2014 23:37:52 +0000 |
On 27 October 2014 23:25, Edgar E. Iglesias <address@hidden> wrote:
> On Mon, Oct 27, 2014 at 12:58:07PM +0000, Peter Maydell wrote:
>> The VIRQ and VFIQ exceptions are (as the comments say) only
>> taken if the CPU is in Non-secure state and the IMO/FMO bits
>> are set to enable virtualized interrupts. Correct the code
>> to actually implement this by using '||' rather than '&&'.
>
> Hi Peter,
>
> Shouldn't this be:
>
> if (secure || ....
>
> ?
Heh, you're right. I didn't look closely enough...
-- PMM