[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP |
Date: |
Tue, 28 Oct 2014 11:38:39 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 24.10.2014 um 15:57 hat Max Reitz geschrieben:
> qemu-img should use QMP commands whenever possible in order to ensure
> feature completeness of both online and offline image operations. For
> the "commit" command, this is relatively easy, so implement it first
> (in the hope that indeed others will follow).
>
> As qemu-img does not have access to QMP (due to QMP being intertwined
> with basically everything in qemu), we cannot directly use QMP, but at
> least use the functions the corresponding QMP commands are using (which
> would be "block-commit", in this case).
>
>
> v14:
> - Patch 3:
> - Pull the optimized code out into an own function [Kevin]
> - Only run the optimized code if the image header, the reftable, a
> single refblock and the L1 table can be described by that single
> refblock [Kevin]
> - Zero out the L1 table before modifying anything else [Kevin]
> - Always set bs->drv to NULL if an error occured which broke the
> in-memory refcount information and thus rendered the BDS unusable
> (because all of the qcow2 code assumes that the in-memory
> information is correct, obviously) [Kevin]
> - Do truncation last, because while it is the eventual goal, it is
> also the structurally least invasive and therefore least important
> operation (we don't want it to fail and leave the BDS unusable)
> [Kevin]
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH v14 10/14] qemu-img: Enable progress output for commit, (continued)
- [Qemu-devel] [PATCH v14 10/14] qemu-img: Enable progress output for commit, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 11/14] qemu-img: Specify backing file for commit, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 13/14] iotests: Add test for backing-chain commits, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 12/14] iotests: Add _filter_qemu_img_map, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty, Max Reitz, 2014/10/24
- Re: [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP, Stefan Hajnoczi, 2014/10/29