[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes |
Date: |
Wed, 29 Oct 2014 01:27:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
>> Yeah, I was wondering if any commands could have <512 bytes response...
>> I sort of convinced myself that the answer was no for ATA commands, but
>> stupidly forgot about packet (SCSI) commands. Their results are
>> obviously shorter than 512 bytes.
>
> Are you referencing the sglist underflow patch? (#5 instead of #3)
Hmm, yeah.
> There were cases in the code already where we /assumed/ that having any bytes
> implied we had at least a sector's worth.
Even for ATAPI?
If there are valid cases for
> the sglist to have less than a sector's worth (SCSI) then I'll need to
> touch that again as well and update all the assumptions in the IDE code
> to look for numbytes instead of numsectors.
cmd_inquiry can return 36 bytes. That can be both PIO and DMA. SeaBIOS
only uses the DMA variant for AHCI.
Paolo
- Re: [Qemu-devel] [PATCH 5/6] ide: Correct handling of malformed/short PRDTs, (continued)
- [Qemu-devel] [PATCH 6/6] ahci: Fix SDB FIS Construction, John Snow, 2014/10/01
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, John Snow, 2014/10/16
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, Michael S. Tsirkin, 2014/10/25
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, Paolo Bonzini, 2014/10/27
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, Stefan Hajnoczi, 2014/10/28
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, John Snow, 2014/10/28
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, Paolo Bonzini, 2014/10/28
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, John Snow, 2014/10/28
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, John Snow, 2014/10/28
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, Paolo Bonzini, 2014/10/29
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, Stefan Hajnoczi, 2014/10/30