qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/17] scsi: Remove 'lun' argument


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 05/17] scsi: Remove 'lun' argument
Date: Wed, 29 Oct 2014 12:35:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0


On 10/29/2014 12:13 PM, Hannes Reinecke wrote:
>> Passing a
>> > NULL SCSIDevice is hard though.
>> > 
> But still can happen even with the current code.
> Look at eg hw/scsi/esp.c:
> 
>     current_lun = scsi_device_find(&s->bus, 0, s->current_dev->id, lun);
>     s->current_req = scsi_req_new(current_lun, 0, buf, s);
>     datalen = scsi_req_enqueue(s->current_req);
> 
> If scsi_device_find() returns NULL we're done for.

That cannot happen:

    s->current_dev = scsi_device_find(&s->bus, 0, target, 0);
    if (!s->current_dev) {
        // No such drive
        s->rregs[ESP_RSTAT] = 0;
        s->rregs[ESP_RINTR] = INTR_DC;
        s->rregs[ESP_RSEQ] = SEQ_0;
        esp_raise_irq(s);
        return 0;
    }

This is in get_cmd, called by handle_satn and handle_s_without_atn
before do_busid_cmd.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]