Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store

[Leon Alrae]

On 29/10/14 01:41, Yongbok Kim wrote:
> 
> Signed-off-by: Yongbok Kim <address@hidden>
> ---
>  target-mips/op_helper.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 7cbf4cf..e878442 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -90,10 +90,10 @@ static inline type do_##name(CPUMIPSState *env, 
> target_ulong addr,      \
>      }                                                                   \
>  }
>  #endif
> +HELPER_LD(lbu, ldub, uint8_t)
> +HELPER_LD(lhu, lduw, uint16_t)
>  HELPER_LD(lw, ldl, int32_t)
> -#ifdef TARGET_MIPS64
>  HELPER_LD(ld, ldq, int64_t)
> -#endif
>  #undef HELPER_LD
>  
>  #if defined(CONFIG_USER_ONLY)
> @@ -118,10 +118,9 @@ static inline void do_##name(CPUMIPSState *env, 
> target_ulong addr,      \
>  }
>  #endif
>  HELPER_ST(sb, stb, uint8_t)
> +HELPER_ST(sh, stw, uint16_t)
>  HELPER_ST(sw, stl, uint32_t)
> -#ifdef TARGET_MIPS64
>  HELPER_ST(sd, stq, uint64_t)
> -#endif
>  #undef HELPER_ST
>  
>  target_ulong helper_clo (target_ulong arg1)

I agree with James, you could squash it into the patch which uses these
functions. Anyway,

Reviewed-by: Leon Alrae <address@hidden>