Re: [Qemu-devel] [PATCH v8 06/27] target-arm: add secure state bit to CPREG hash

[Peter Maydell]

On 31 October 2014 12:28, Peter Maydell <address@hidden> wrote:
> On 30 October 2014 21:28, Greg Bellows <address@hidden> wrote:

>>  static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
>>                                     void *opaque, int state,
>> -                                   int crm, int opc1, int opc2)
>> +                                   int crm, int opc1, int opc2, int nsbit)
>
> Again, I think I'd rather we put 'nsbit' after 'state' rather than at the end.
> Also you probably want 'bool ns' rather than 'int nsbit'.

...actually, what you want here is "int secstate" and pass in either
ARM_CP_SECSTATE_S or ARM_CP_SECSTATE_NS. (This matches the way the
'state' parameter takes one of the ARM_CP_STATE_* values.)

-- PMM