Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

[Stefan Hajnoczi]

On Thu, Oct 30, 2014 at 10:36:35AM +0100, Kevin Wolf wrote:
> Am 30.10.2014 um 10:27 hat Stefan Hajnoczi geschrieben:
> > The guest may legitimately use raw devices that contain image format
> > data.  Imagine tools similar to libguestfs.
> > 
> > It's perfectly okay for them to lay out image format data onto a raw
> > device.
> > 
> > Probing is the problem, not putting image format data onto a raw device.
> 
> Agreed, that's why any restrictions only apply when probing was used to
> detect a raw image. If you want to do anything exotic like storing a
> qcow2 image for nested virt on a disk that is a raw image in the host,
> then making sure to pass format=raw shouldn't be too much.

Because at that point the solution is way over-engineered.

Probing checks should be in the QEMU command-line code, not sprinkled
across the codebase and even at run-time.

Isn't Markus approach much simpler and cleaner?

Stefan

pgptSUHigKdls.pgp
Description: PGP signature