qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] block: Add bdrv_get_node_name


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/4] block: Add bdrv_get_node_name
Date: Thu, 30 Oct 2014 15:33:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 10/28/2014 11:04 PM, Fam Zheng wrote:
> This returns the node name of a BDS. Remove the TODO comment and expect
> the callers to be explicit.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  block.c               | 6 +++++-
>  include/block/block.h | 1 +
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 

Can still return NULL because we don't have Jeff's patches for
auto-assigning a node name everywhere, right?  But that doesn't matter
in the context of this patch, so:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]