qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 02/47] Tests: QEMUSizedBuffer/QEMUBuffer


From: David Gibson
Subject: Re: [Qemu-devel] [PATCH v4 02/47] Tests: QEMUSizedBuffer/QEMUBuffer
Date: Mon, 3 Nov 2014 12:02:20 +1100
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Oct 03, 2014 at 06:47:08PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> * Please comment on separate thread for this QEMUSziedBuffer patch *
> 
> Modify some of tests/test-vmstate.c to use the in memory file based
> on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and
> the associated memory backed QEMUFile type.
> 
> Only some of the tests are changed so that the fd backed QEMUFile is
> still tested.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: David Gibson <address@hidden>

Looks ok, although I do wonder if the removal of some of the test
paths for regular files is a concern.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: pgpn_nulmkWOO.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]