Re: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes

[Paolo Bonzini]

On 31/10/2014 21:03, John Snow wrote:
> - Adjust the prepare_buf() callback to return, simply, the number
>   of bytes it was able to prepare, or -1 on error. This resolves
>   an ambiguity around the nature of its return code meaning
>   "no sectors" or "no bytes" which led to bad error pathways.

Much nicer!  Sounds obvious, but hindsight is 20/20...

> John Snow (3):
>   ide: repair PIO transfers for cases where nsector > 1
>   ahci: unify sglist preparation
>   ide: Correct handling of malformed/short PRDTs
> 
>  hw/ide/ahci.c     | 33 ++++++++++++++++++++++++++-------
>  hw/ide/core.c     | 14 ++++++++++++--
>  hw/ide/internal.h | 13 +++++++------
>  hw/ide/macio.c    |  7 ++++++-
>  hw/ide/pci.c      | 27 +++++++++++++++++++++------
>  5 files changed, 72 insertions(+), 22 deletions(-)
> 

Reviewed-by: Paolo Bonzini <address@hidden>

Paolo