Re: [Qemu-devel] [PATCH v2] translate-all: Marked map_exec() with the 'unused' attribute

[Peter Maydell]

On 3 November 2014 08:11, SeokYeon Hwang <address@hidden> wrote:
> Marked map_exec() with the 'unused' attribute to avoid '-Wunused-function' on 
> clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <address@hidden>
> ---
>  translate-all.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index ba5c840..9d150fb 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
>  }
>
>  #ifdef _WIN32
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
>  {
>      DWORD old_protect;
>      VirtualProtect(addr, size,
>                     PAGE_EXECUTE_READWRITE, &old_protect);
>  }
>  #else
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
>  {
>      unsigned long start, end, page_size;
>
> --
> 2.1.0

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM