Re: [Qemu-devel] [PATCH] vdi: wrapped uuid_unparse() in #ifdef

[Paolo Bonzini]

On 31/10/2014 09:02, SeokYeon Hwang wrote:
> Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or 
> later.
> 
> Signed-off-by: SeokYeon Hwang <address@hidden>
> ---
>  block/vdi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/block/vdi.c b/block/vdi.c
> index 19701ee..e1d211c 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -137,12 +137,14 @@ static inline int uuid_is_null(const uuid_t uu)
>      return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0;
>  }
>  
> +# if defined(CONFIG_VDI_DEBUG)
>  static inline void uuid_unparse(const uuid_t uu, char *out)
>  {
>      snprintf(out, 37, UUID_FMT,
>              uu[0], uu[1], uu[2], uu[3], uu[4], uu[5], uu[6], uu[7],
>              uu[8], uu[9], uu[10], uu[11], uu[12], uu[13], uu[14], uu[15]);
>  }
> +# endif
>  #endif
>  
>  typedef struct {
> 

Reviewed-by: Paolo Bonzini <address@hidden>