qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked
Date: Mon, 3 Nov 2014 22:49:50 +0000

On 3 November 2014 22:06, Greg Bellows <address@hidden> wrote:
> You seem to not be a fan of the fields setting moved around and Fabian
> appears to have done this in a number of places.  I left them as is because
> I found the changes to add consistency and compactness.

I particularly dislike it where it makes the diffs harder
to read (as in this instance where it disguises the fact
that there's only actually been one field that's changed).

> Would you like me to undo any such changes?

I wouldn't bother except for the patches where I
specifically mentioned it.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]