[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options |
Date: |
Tue, 04 Nov 2014 16:55:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/02/2014 07:39 AM, Quan Xu wrote:
[meta-comment] This message appears to have a cover letter; but you
failed to properly set the 'In-Reply-To' header; when each patch of your
series appears as a top-level thread instead of a reply to the cover
letter, it is harder to review.
> Signed-off-by: Quan Xu <address@hidden>
> ---
> configure | 14 ++++++++++++++
> hmp.c | 7 +++++++
> qapi-schema.json | 17 +++++++++++++++--
> qemu-options.hx | 13 +++++++++++--
> tpm.c | 7 ++++++-
> 5 files changed, 53 insertions(+), 5 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -2853,10 +2853,11 @@
> # An enumeration of TPM types
> #
> # @passthrough: TPM passthrough type
> +# @xenstubdoms: TPM xenstubdoms type
Missing a '(since 2.3)' designation.
> #
> # Since: 1.5
> ##
> -{ 'enum': 'TpmType', 'data': [ 'passthrough' ] }
> +{ 'enum': 'TpmType', 'data': [ 'passthrough', 'xenstubdoms' ] }
>
> ##
> # @query-tpm-types:
> @@ -2884,6 +2885,16 @@
> { 'type': 'TPMPassthroughOptions', 'data': { '*path' : 'str',
> '*cancel-path' : 'str'} }
>
> +# @TPMXenstubdomsOptions:
> +#
> +# Information about the TPM xenstubdoms type
> +#
> +# Since: > 2.1.0
2.1 is wrong; the earliest you can get this into the tree is 2.3
(because you've missed soft freeze for 2.2).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature