qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 RESEND 3/4] qapi-schema: Add version info for


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 RESEND 3/4] qapi-schema: Add version info for transaction types
Date: Tue, 04 Nov 2014 17:27:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 11/03/2014 02:47 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  qapi-schema.json | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 1ddd395..48ba583 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1256,6 +1256,8 @@
>  # @transaction.
>  #
>  # Since 1.1
> +# drive-backup since 1.6
> +# blockdev-snapshot-internal-sync since 1.7
>  # blockdev-backup since 2.3

Aha - you (almost) addressed my comment from 2/4 - you missed that abort
was also added in 1.6, alongside drive-backup.

I'd be okay if you squashed this in with 2/4.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]