Re: [Qemu-devel] [PATCH 1/6] configure: add dependency from libxml2

[Denis V. Lunev]

On 05/11/14 10:32, Michael Tokarev wrote:
> 29.10.2014 16:38, Denis V. Lunev wrote:
> > This dependency is required for adequate Parallels images support.
> > Typically the disk consists of several images which are glued by
> > XML disk descriptor. Also XML hides inside several important parameters
> > which are not available in the image header.
> []
> > +# check for libxml2
> > +if test "$libxml2" != "no" ; then
> > +    if $pkg_config --exists libxml-2.0; then
> > +        libxml2="yes"
> > +        libxml2_cflags=$($pkg_config --cflags libxml-2.0)
> > +        libxml2_libs=$($pkg_config --libs libxml-2.0)
> > +        QEMU_CFLAGS="$QEMU_CFLAGS $libxml2_cflags"
> > +        libs_softmmu="$libs_softmmu $libxml2_libs"
> > +        libs_tools="$libs_tools $libxml2_libs"
> Please NO.  NO NO NO NO :)
>
> Create a separate make variable, $LIBXML or something,
> and add it as a parallels.o dependency, not libs_softmmu
> etc.  Ditto for the cflags.  See examples -- libiscsi,
> libcurl, librbd - in block/Makefile.objs.
no prob
> After that, I think we'll move parallels.o to be a module ;)
>
> (Cc'ing Fam)
what does it mean for me? Could you point out the place
to read/understand the difference.

Thank you in advance,
    Den