qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ui/input: strictly check console in finding inp


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] ui/input: strictly check console in finding input handler
Date: Wed, 05 Nov 2014 09:47:47 +0100

On Mi, 2014-11-05 at 00:49 +0800, Amos Kong wrote:
> qemu_input_find_handler() prefers a handler associated with con.
> But if none exists, it takes any. This patch added a parameter
> to strictly check console, in case we want to input event to
> special console.
> 
> 'input-send-event' has a parameter to assign special console,
> so we should enable strict checking in finding handler.

I don't think we want do that by default.  It only matters in case of a
multiseat setup where you actually have multiple input devices of the
same kind.  Which isn't a very typical use case.

Options I see are:

  (a) Turn console into an optional parameter, do strict checking in
      case it is present.
  (b) Add a optional 'strict' parameter.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]