[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a n
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error. |
Date: |
Wed, 05 Nov 2014 13:44:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 05/11/2014 12:11, Max Reitz wrote:
>
> Of course I understand, but this patch doesn't make matters worse, as
> long as there are not systems which have negative values for errno
> (which I think we generally assume not to exist throughout qemu). That's
> why I'm fine with it. We should fix the callers but I don't see why we
> shouldn't apply this patch as well.
>
> A similar issue already came up and led to commit b276d2499, where
> callers of error_setg_errno() assumed that it would not clobber errno,
> so we fixed some of the callers but also applied that commit which just
> saves errno because there's no reason not to.
I think side effect are a different matter than misuse of QEMU.
There are "only" 157 calls to error_setg_errno; 67 use "errno" as the
argument, and 4 use an explicit errno value (one of them is the wrong
-EBUSY). The other 86 seem correct and should not be hard to audit.
Let's instead add an assertion check to error_setg_errno.
Paolo
- [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., SeokYeon Hwang, 2014/11/05
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., Max Reitz, 2014/11/05
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., Paolo Bonzini, 2014/11/05
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., SeokYeon Hwang, 2014/11/05
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., Markus Armbruster, 2014/11/05
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., SeokYeon Hwang, 2014/11/05
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., Markus Armbruster, 2014/11/06
- Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error., SeokYeon Hwang, 2014/11/06