Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

[Paolo Bonzini]

On 05/11/2014 14:28, Michael S. Tsirkin wrote:
> > I think bypassing the question by converting to realize makes the most
> > sense...
>
> I'm fine with doing that but Markus's patches wouldn't
> yet have solved the problem by themselves since init
> is still around, right?
> 
> This probably means fixing this bug can't justify
> merging the realize patchset after freeze.

Yes, I agree.  I meant that the API is not very well defined.  I would
handle everything else on a case-by-case basis, by reviewing each init
function that is converted to realize.

Since the patch was for an out-of-tree device, it can wait for 2.3 anyway.

Paolo