Re: [Qemu-devel] [PATCH] seccomp: change configure to avoid arm 32 to break

[Eduardo Otubo]

On Wed, Nov 05, 2014 at 03:35:09PM -0500, Paul Moore wrote:
> On Wednesday, November 05, 2014 08:08:06 PM Peter Maydell wrote:
> > On 5 November 2014 19:46, Paul Moore <address@hidden> wrote:
> > > On Wednesday, November 05, 2014 05:08:20 PM Peter Maydell wrote:
> > >> On 5 November 2014 16:47, Eduardo Otubo wrote:
> > >> > Right now seccomp is breaking the compilation of Qemu on armv7l due
> > >> > to libsecomp current lack of support for this arch. This problem is
> > >> > already fixed on libseccomp upstream but no release date for that is
> > >> > scheduled to far. This patch disables support for seccomp on armv7l
> > >> > temporarily until libseccomp does a new release. Then I'll remove the
> > >> > hack and update libseccomp dependency on configure script.
> > >> > 
> > >> > Related bug: https://bugs.launchpad.net/qemu/+bug/1363641
> > > 
> > > ...
> > > 
> > >> (How are upstream proposing to fix this anyway? I couldn't
> > >> figure that out from the mailing list thread.)
> > > 
> > > The problem was that the released version of libseccomp has some "holes"
> > > in
> > > the internal syscall table for 32-bit ARM with respect to all of the other
> > > supported architectures.  The current libseccomp upstream has some
> > > additional tooling and checks to ensure that the different ABI syscall
> > > tables are kept in sync to prevent something like this from happening in
> > > the future.
> > 
> > OK. So should we make QEMU say "if x86_64 or i386, require
> > seccomp 2.1 or better, else require 2.2 or better"?

I don't think it's worth to point to a non existing version right now,
it might confuse people.

> 
> I would probably just limit QEMU/seccomp to x86_64 and x86.  Once we have the 
> new release that fixes everything we can start worrying about versions and 
> different ABIs.

That's fine for me, since is a temporary fix. I'll just go and rewrite
this patch, then.

Paul, do you have any plans for a new libseccomp release?

Regards,

-- 
Eduardo Otubo
ProfitBricks GmbH