Re: [Qemu-devel] [PATCH] vl: rework smp_parse

[Eduardo Habkost]

On Fri, Nov 07, 2014 at 01:23:12PM +0100, Andrew Jones wrote:
> On Fri, Nov 07, 2014 at 10:16:06AM -0200, Eduardo Habkost wrote:
> > On Fri, Nov 07, 2014 at 12:21:26PM +0100, Andrew Jones wrote:
> > > On Fri, Nov 07, 2014 at 10:52:31AM +0100, Andrew Jones wrote:
[...]
> > > After talking with Igor, it seems like the better approach is to get
> > > smp parameters converted over to machine properties, allowing us to
> > > use the old parser for old machine types, and the new for new. I'll
> > > look into it.
> > 
> > While we work on that, I think we could at least change the existing
> > code to abort if sockets*cores*threads < smp_cpus (when all 4 options
> > are present in the command-line), and never adjust any option silently.
> 
> But then we'll end up with 3 different behaviors. If we do anything for
> the short-term, then maybe it should only be to add warnings. The
> machine property version will then convert those warnings to aborts for
> new machines types.

Oh, in that specific case I didn't even consider keeping the old
behavior, so there wouldn't be 3 different behaviors to emulate.

Silently changing smp_threads when it was explicitly set in the
command-line is so wrong that I would always prefer to see QEMU
aborting.

-- 
Eduardo