Re: [Qemu-devel] [Qemu-ppc] [PATCH] kvm: Fix memory slot page alignment logic

[Alexander Graf]

On 07.11.14 22:18, Alexander Graf wrote:
> Memory slots have to be page aligned to get entered into KVM. There
> is existing logic that tries to ensure that we pad memory slots that
> are not page aligned to the biggest region that would still fit in the
> alignment requirements.
> 
> Unfortunately, that logic is broken. It tries to calculate the start
> offset based on the region size.
> 
> Fix up the logic to do the thing it was intended to do and document it
> properly in the comment above it.
> 
> With this patch applied, I can successfully run an e500 guest with more
> than 3GB RAM (at which point RAM starts overlapping subpage memory regions).
> 
> Cc: address@hidden
> Signed-off-by: Alexander Graf <address@hidden>

If everyone agrees that this patch does indeed do what the code is
intended to do (I think it's quite correct, to be 100% right it should
use getpagesize() rather than TARGET_PAGE_SIZE), this should go into 2.2
still.


Alex