[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty |
Date: |
Tue, 11 Nov 2014 21:41:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/11/2014 06:34 AM, Max Reitz wrote:
> Add a command line option for adding a QMP monitor using pretty JSON
> formatting.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-options.hx | 8 ++++++++
> vl.c | 15 ++++++++++-----
> 2 files changed, 18 insertions(+), 5 deletions(-)
>
Minor grammar suggestions:
> diff --git a/qemu-options.hx b/qemu-options.hx
> index da9851d..bc7b4c2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2788,6 +2788,14 @@ STEXI
> @findex -qmp
> Like -monitor but opens in 'control' mode.
> ETEXI
> +DEF("qmp-pretty", HAS_ARG, QEMU_OPTION_qmp_pretty, \
> + "-qmp-pretty dev like -qmp but uses pretty JSON formatting\n",
maybe s/dev like -qmp/dev: like -qmp,/
> + QEMU_ARCH_ALL)
> +STEXI
> address@hidden -qmp-pretty @var{dev}
> address@hidden -qmp-pretty
> +Like -qmp but uses pretty JSON formatting.
maybe s/-qmp/-qmp,/
Either way,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature