Re: [Qemu-devel] [PATCH 2/2] acpi-build: Make DPRINTF working for acpi-build

[Gonglei]

On 2014/11/13 16:01, Markus Armbruster wrote:

> <address@hidden> writes:
> 
>> From: Gonglei <address@hidden>
>>
>> Signed-off-by: Gonglei <address@hidden>
>> ---
>>  hw/i386/acpi-build.c | 18 ++++++++++++------
>>  1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>> index 4ab44bf..8cec9aa 100644
>> --- a/hw/i386/acpi-build.c
>> +++ b/hw/i386/acpi-build.c
>> @@ -67,6 +67,14 @@
>>  
>>  #define ACPI_BUILD_TABLE_SIZE             0x20000
>>  
>> +/* #define DEBUG_ACPI_BUILD */
>> +#ifdef DEBUG_ACPI_BUILD
>> +#define ACPI_BUILD_DPRINTF(fmt, ...)        \
>> +    do {printf("ACPI_BUILD: " fmt, ## __VA_ARGS__); } while (0)
>> +#else
>> +#define ACPI_BUILD_DPRINTF(fmt, ...)
>> +#endif
>> +
>>  typedef struct AcpiCpuInfo {
>>      DECLARE_BITMAP(found_cpus, ACPI_CPU_HOTPLUG_ID_LIMIT);
>>  } AcpiCpuInfo;
>> @@ -245,8 +253,6 @@ static void acpi_get_pci_info(PcPciInfo *info)
>>  #define ACPI_BUILD_APPNAME6 "BOCHS "
>>  #define ACPI_BUILD_APPNAME4 "BXPC"
>>  
>> -#define ACPI_BUILD_DPRINTF(level, fmt, ...) do {} while (0)
>> -
>>  #define ACPI_BUILD_TABLE_FILE "etc/acpi/tables"
>>  #define ACPI_BUILD_RSDP_FILE "etc/acpi/rsdp"
>>  #define ACPI_BUILD_TPMLOG_FILE "etc/tpm/log"
> 
> Have you considered replacing ACPI_BUILD_DPRINTF() by tracepoints?
> 
> [...]

Not yet. I just think the change is simpler at this time ;)

Maybe we can improve the file's log by tracing framework.

Best regards,
-Gonglei