Re: [Qemu-devel] [PATCH 0/9] valgrind/i386/s390x: memcheck false positives

[Paolo Bonzini]

On 30/10/2014 10:36, Christian Borntraeger wrote:
> This series avoids most memcheck false positives in KVM ioctls on s390x
> and x86_64.
> 
> Please review and consider for 2.2 or later. Some of these things could
> also be fixed in valgrind, but it will take a while until these changes
> hit a release or distros.
> 
> The series is also available via signed tag:
> 
> The following changes since commit 3e9418e160cd8901c83a3c88967158084f5b5c03:
> 
>   Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously" 
> (2014-10-27 15:05:09 +0000)
> 
> are available in the git repository at:
> 
>   git://github.com/borntraeger/qemu.git tags/memcheck
> 
> for you to fetch changes up to e5bcf96f709e57a54188ffa6a988b6acb603df7a:
> 
>   valgrind/s390x: avoid false positives on KVM_SET_FPU ioctl (2014-10-30 
> 10:08:49 +0100)
> 
> ----------------------------------------------------------------
> valgrind/i386/s390x: memcheck false positives
> 
> Let's avoid most memcheck false positives in KVM ioctls.
> 
> ----------------------------------------------------------------
> Christian Borntraeger (9):
>       valgrind: avoid false positives in KVM_GET_DIRTY_LOG ioctl
>       valgrind/i386: avoid false positives on KVM_SET_CLOCK ioctl
>       valgrind/i386: avoid false positives on KVM_SET_PIT ioctl
>       valgrind/i386: avoid false positives on KVM_SET_XCRS ioctl
>       valgrind/i386: avoid false positives on KVM_SET_MSRS ioctl
>       valgrind/i386: avoid false positives on KVM_SET_MSRS(TSC) ioctl
>       valgrind/i386: avoid false positives on KVM_GET_MSRS ioctl
>       valgrind/i386: avoid false positives on KVM_SET_VCPU_EVENTS ioctl
>       valgrind/s390x: avoid false positives on KVM_SET_FPU ioctl
> 
>  hw/i386/kvm/clock.c | 3 +--
>  hw/i386/kvm/i8254.c | 2 +-
>  kvm-all.c           | 2 +-
>  target-i386/kvm.c   | 9 +++++----
>  target-s390x/kvm.c  | 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)
> 
> 
> 

Christian, when you respin can you add another one in
kvm_irqchip_add_adapter_route?  Coverity reports kroute.pad as
uninitialized.

Paolo